Fix PMDK version in INSTALLING.md according to release #719
Conversation
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KFilipek)
INSTALLING.md, line 179 at r1 (raw file):
git clone https://github.com/pmem/pmdk cd pmdk make -j8
actually you could change that -j8 which may not be safe on some machnies - make it (everywhere in this file) make -j$(nproc), like we do it in our CI, e.g. https://github.com/pmem/pmemkv/blob/master/utils/docker/images/install-memkind.sh#L34
KFilipek
force-pushed
the
task-alignment_to_version
branch
from
1e40658
to
551d168
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
INSTALLING.md, line 179 at r1 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
actually you could change that
-j8which may not be safe on some machnies - make it (everywhere in this file)make -j$(nproc), like we do it in our CI, e.g. https://github.com/pmem/pmemkv/blob/master/utils/docker/images/install-memkind.sh#L34
Done.
Codecov Report
@@ Coverage Diff @@
## master #719 +/- ##
==========================================
- Coverage 86.65% 85.99% -0.67%
==========================================
Files 22 22
Lines 2023 2020 -3
==========================================
- Hits 1753 1737 -16
- Misses 270 283 +13
|
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @KFilipek)
INSTALLING.md, line 41 at r2 (raw file):
cd ./build cmake .. # run CMake make # build everything
pls, here too; + update commit message
INSTALLING.md, line 95 at r2 (raw file):
cd mybuild cmake ~/pmemkv # this directory should contain the source code of pmemkv make
.
INSTALLING.md, line 259 at r2 (raw file):
... cmake .. -DCPACK_GENERATOR="$GEN" -DCMAKE_INSTALL_PREFIX=/usr make package
.
There was a problem hiding this comment.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @lukaszstolarczuk)
INSTALLING.md, line 41 at r2 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
pls, here too; + update commit message
Done.
INSTALLING.md, line 95 at r2 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
.
Done.
INSTALLING.md, line 259 at r2 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
.
Done.
KFilipek
force-pushed
the
task-alignment_to_version
branch
from
551d168
to
b6ad2e6
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @KFilipek and @lukaszstolarczuk)
INSTALLING.md, line 204 at r3 (raw file):
./autogen.sh ./configure make
you can also update it for memkind... (here and in "on Fedora" section)
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, 2 unresolved discussions (waiting on @KFilipek and @lukaszstolarczuk)
a discussion (no related file):
Can you please also add in README file, in docs section on top of the file, another version of documentation, i.a.:
v1.2 - https://pmem.io/pmemkv/v1.2/doxygen/index.html
- Change value 1.9 to 1.10 to be consistent with build requirements - Add make parameters to build instructions - Add new link to a new version of documentation
KFilipek
force-pushed
the
task-alignment_to_version
branch
from
b6ad2e6
to
297ced8
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @lukaszstolarczuk)
a discussion (no related file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
Can you please also add in README file, in docs section on top of the file, another version of documentation, i.a.:
v1.2 - https://pmem.io/pmemkv/v1.2/doxygen/index.html
Done.
INSTALLING.md, line 204 at r3 (raw file):
Previously, lukaszstolarczuk (Łukasz Stolarczuk) wrote…
you can also update it for memkind... (here and in "on Fedora" section)
Instruction from Memkind repository doesn't have "-j" parameter
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, 1 of 1 files at r4.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
Change value 1.9 to 1.10 to be consistent with build requirements.
I can also add some minor changes around, if you will see.
This change is