Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Testing RakLib IPv6 support #1937

Closed
wants to merge 7 commits into from
Closed

Testing RakLib IPv6 support #1937

wants to merge 7 commits into from

Conversation

dktapps
Copy link
Member

@dktapps dktapps commented Jan 19, 2018

Introduction

see pmmp/RakLib#22 for the library changes.

@dktapps dktapps added PR: Contribution Status: Insufficiently Tested Category: Network Related to the internal network architecture labels Jan 19, 2018
@dktapps
Copy link
Member Author

dktapps commented Feb 13, 2018

This needs to take into account that PHP can be compiled without IPv6 support. It should either bail or not open the IPv6 interface if IPv6 is not available.

@dktapps dktapps mentioned this pull request Aug 4, 2018
Closed
@dktapps dktapps changed the base branch from master to release/3.4 October 25, 2018 18:41
@dktapps
Implemented IPv6 support
e9998a9 
Added two new server.properties options:
- server-ipv6: defaults to "::"
- server-portv6: defaults to the same value as "server-port"
@dktapps
MCPE scans on IPv6 port 19133, so make the default the same
ef9dae1
@dktapps
Make sure IPv6 support is present
9b83569
@dktapps
Default to :: when property is empty
aa8e7da
@dktapps
Copy link
Member Author

dktapps commented Dec 15, 2018

/ban-ip appears incapable of banning IPv6 addresses.

@dktapps dktapps closed this Dec 26, 2018
@dktapps dktapps changed the base branch from release/3.4 to release/3.5 December 26, 2018 23:26
@dktapps dktapps reopened this Dec 26, 2018
@dktapps dktapps closed this Jan 2, 2019
@dktapps dktapps changed the base branch from release/3.5 to 3.5 January 2, 2019 10:11
@dktapps dktapps reopened this Jan 2, 2019
@TheAz928
Copy link

TheAz928 commented Jan 26, 2019 •
edited

This pull request is very useful if all problems are solved, which is possible to solve. Please consider doing this first because many vps/dedicated providers give more ipv6 than ipv4, and those default ports are kinda a new priority now. Thanks.

@dktapps
Copy link
Member Author

dktapps commented Jan 29, 2019

It's not as trivial as it looks. There are a lot of internals that are entirely unprepared for IPv6. While this allows players to join via an IPv6 interface, there are a lot of other things that still need to be addressed.

@dktapps dktapps closed this Feb 22, 2019
@dktapps dktapps changed the base branch from 3.5 to 3.6 February 22, 2019 18:05
@dktapps dktapps reopened this Feb 22, 2019
@dktapps dktapps closed this Mar 29, 2019
@dktapps dktapps changed the base branch from 3.6 to 3.7 March 30, 2019 00:13
@dktapps dktapps reopened this Mar 30, 2019
@dktapps dktapps changed the base branch from 3.7 to stable April 14, 2019 21:51
@SOF3
Copy link
Member

SOF3 commented Dec 15, 2019

Please explain what this pull request is blocking on. It is almost two years old.

@dktapps
Copy link
Member Author

dktapps commented Dec 15, 2019

There are some problems with /ban-ip as already mentioned, but the bigger problem is error handling.

Currently, the server will crash if either IPv4 or IPv6 fails to bind. With this in mind, it should be possible to disable all but one network interface.

@dktapps dktapps mentioned this pull request May 18, 2020
Closed
@dktapps dktapps changed the base branch from stable to master November 2, 2021 20:58
@dktapps dktapps closed this Nov 2, 2021
@dktapps dktapps deleted the ipv6 branch November 2, 2021 23:12
@dktapps dktapps added Type: Enhancement Contributes features or other improvements to PocketMine-MP and removed Type: Contribution labels Nov 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Category: Network Related to the internal network architecture Resolution: Stale Status: Insufficiently Tested Type: Enhancement Contributes features or other improvements to PocketMine-MP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dktapps @TheAz928 @SOF3 @dschwartz783