Changed PermissibleBase to trait to remove boilerplate #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SOF3
added
Category: API
|
It's been discussed to instead keep this as a subcomponent and remove the Permissible implementation from Player. This would solve the problem as well, along with others related to code complexity. |
|
This change is better combined with the removal of other implementations from Player, hopefully including Vector3, Entity, etc. |
|
3c677bd resolves the boilerplate issue, but it also creates conflicts with this pull. Since the majority of its purpose has been obsoleted, I'm closing this. |
dktapps
added
Type: Contribution
and removed
Category: Cosmetic
dktapps
added
Type: Enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
Implementing Permissible is based on PermissibleBase, but redirecting the method calls produces a lot of boilerplate code. This PR converts PermissibleBase to an actual trait that implements the Permissible methods.
Changes
API changes
Behavioural changes
none
Backwards compatibility
Classes that extend/contain PermissibleBase have to switch to
use PermissibleTrait;. Remember to callinitPermissible()andclearPermissions().Tests
Works when player join and quits with almost no plugins. Not everything has been carefully tested.