-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer #4
Composer #4
Conversation
"ext-pthreads": "3.1.6" | ||
}, | ||
"autoload": { | ||
"classmap": ["protocol/", "server/", "RakLib.php", "Binary.php"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be replaced with "autoload": { "psr-4"; { "RakLib\\": "." } }
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer docs say you can't use relative directories. I'll give this a try though.
protected function getLong($signed = true){ | ||
return Binary::readLong($this->get(8), $signed); | ||
protected function getLong(){ | ||
return Binary::readLong($this->get(8)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Irrelevant to this pull request?
@@ -72,6 +72,8 @@ class SessionManager{ | |||
protected $block = []; | |||
protected $ipSec = []; | |||
|
|||
protected $serverId; | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Irrelevant to this pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(for both comments) Composer static analysis
Add composer support to RakLib, this doesn't affect the current method of installing RakLib inside of PocketMine