-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Composer #4
Composer #4
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1,3 @@ | ||
.idea/ | ||
|
||
/vendor/ |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,12 @@ | ||
{ | ||
"name": "pmmp/rak-lib", | ||
"description": "RakNet server implementation written in PHP", | ||
"type": "library", | ||
"license": "GPL-3.0", | ||
"require": { | ||
"ext-pthreads": "3.1.6" | ||
}, | ||
"autoload": { | ||
"classmap": ["protocol/", "server/", "RakLib.php", "Binary.php"] | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -41,8 +41,8 @@ protected function get($len){ | |
return $len === 1 ? $this->buffer{$this->offset++} : substr($this->buffer, ($this->offset += $len) - $len, $len); | ||
} | ||
|
||
protected function getLong($signed = true){ | ||
return Binary::readLong($this->get(8), $signed); | ||
protected function getLong(){ | ||
return Binary::readLong($this->get(8)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Irrelevant to this pull request? |
||
} | ||
|
||
protected function getInt(){ | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -72,6 +72,8 @@ class SessionManager{ | |
protected $block = []; | ||
protected $ipSec = []; | ||
|
||
protected $serverId; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Irrelevant to this pull request? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. (for both comments) Composer static analysis |
||
public $portChecking = true; | ||
|
||
public function __construct(RakLibServer $server, UDPServerSocket $socket){ | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be replaced with
"autoload": { "psr-4"; { "RakLib\\": "." } }
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Composer docs say you can't use relative directories. I'll give this a try though.