Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fast binary serializer for PalettedBlockArray #36

Open
dktapps opened this issue Feb 28, 2023 · 0 comments
Open

Implement fast binary serializer for PalettedBlockArray #36

dktapps opened this issue Feb 28, 2023 · 0 comments

Comments

@dktapps
Copy link
Member

dktapps commented Feb 28, 2023

Serializing palettes is one of the slowest parts of FastChunkSerializer, due to getPalette() building an array, and then passing the result into pack(), which has slow format code parsing and also has to validate every element to check that it's actually an integer.

We can bypass this entirely by implementing a native binary encoder for PalettedBlockArray, which would make FastChunkSerializer quite a bit faster.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant