Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unintuitive object compare behaviour #56

Open
dktapps opened this issue Apr 2, 2021 · 0 comments
Open

Remove unintuitive object compare behaviour #56

dktapps opened this issue Apr 2, 2021 · 0 comments
Labels
Clear limitations pthreads' limits MUST NOT be disguised behind any magic or potentially surprising behaviour

Comments

@dktapps
Copy link
Member

dktapps commented Apr 2, 2021

As described by this test, == between two Threaded objects actually tells whether the two objects are the same underlying Threaded object.

This is no longer useful because we don't form connection chains, so a Threaded object will always be referred to by the same Zend object.

In addition, == is actually expected to recursively compare properties. While this is obviously insanely inefficient, it's what's expected by PHP. This is yet another stroke of krakjoe genius repurposing language features for things they weren't designed for.

@dktapps dktapps added the Clear limitations pthreads' limits MUST NOT be disguised behind any magic or potentially surprising behaviour label Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Clear limitations pthreads' limits MUST NOT be disguised behind any magic or potentially surprising behaviour
Projects
None yet
Development

No branches or pull requests

1 participant