Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Account for potential overflow of various tags #45

Open
dktapps opened this issue Jan 7, 2019 · 0 comments
Open

Account for potential overflow of various tags #45

dktapps opened this issue Jan 7, 2019 · 0 comments
Labels
Type: Bug

Comments

@dktapps
Copy link
Member

dktapps commented Jan 7, 2019

The maximum possible size of a TAG_ByteArray's payload is 2GiB, but this is not currently capped by the library. While this is a less immediate problem than the old StringTag bug, this also needs to be catered for.

This is also a problem for TAG_List and TAG_IntArray since this uses a 4-byte integer prefix to store length as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dktapps