Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect duplicated keys on CompoundTag deserialization #54

Closed
dktapps opened this issue Dec 6, 2019 · 1 comment
Closed

Detect duplicated keys on CompoundTag deserialization #54

dktapps opened this issue Dec 6, 2019 · 1 comment

Comments

@dktapps
Copy link
Member

dktapps commented Dec 6, 2019

While no sane implementation should allow this, there is a possibility in the CompoundTag binary format for the same key to appear multiple times. If this occurs, the last tag will overwrite the previous ones, or potentially crash due to mismatched type.

This should be detected as data corruption and exceptions thrown appropriately instead.

@dktapps
Copy link
Member Author

dktapps commented Feb 24, 2020

Fixed by 1ba981d.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant