Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashing tasks don't kill Worker #34

Closed
dktapps opened this issue Dec 7, 2020 · 1 comment
Closed

Crashing tasks don't kill Worker #34

dktapps opened this issue Dec 7, 2020 · 1 comment

Comments

@dktapps
Copy link
Member

dktapps commented Dec 7, 2020

krakjoe/pthreads#724

Despite krakjoe's claim that this is expected behaviour, I think it's severely problematic:

  • Memory issues on workers will crash all tasks that get submitted, without any indication to the main thread what's going on. This can happen due to, for example, overpopulation of thread-local storage.
  • register_shutdown_function() is unable to capture fatal errors because it's never called (?!?!?!?!?!?)
  • The parent thread has no idea that there might be a persistent state issue with a worker, causing it to continue to post tasks that subsequently fail too

One possible option is to just scrap Worker and reimplement it in userland (this isn't actually terribly difficult).

@dktapps
Copy link
Member Author

dktapps commented May 16, 2023

Fixed by 5c595c1.

@dktapps dktapps closed this as completed May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant