Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to troika-three-text 0.33 and remove the forked r3f-troika #150

Merged
merged 1 commit into from
Oct 2, 2020
Merged

Update to troika-three-text 0.33 and remove the forked r3f-troika #150

merged 1 commit into from
Oct 2, 2020

Conversation

lojjic
Copy link
Contributor

@lojjic lojjic commented Oct 2, 2020

Included in this update:

  • The derived material now automatically picks up changes to the base material; the hacky code for manually forwarding props is no longer needed and has been removed.
  • Using materials defined as ES6 classes no longer errors; see Distort and Wobble material constructor problem #89.
  • Text and all its dependencies are now tree-shakeable.

@lojjic
Update to troika-three-text 0.33 and remove the forked r3f-troika
b903fdc 
Included in this update:
- The derived material now automatically picks up changes to the base material; the hacky code for manually forwarding props is no longer needed and has been removed.
- Using materials defined as ES6 classes no longer errors; see pmndrs#89.
- Text and all its dependencies are now tree-shakeable.
@lojjic lojjic mentioned this pull request Oct 2, 2020
Closed
@drcmda drcmda merged commit 2d3575a into pmndrs:master Oct 2, 2020
@drcmda
Copy link
Member

drcmda commented Oct 2, 2020

incredible! thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lojjic @drcmda