Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e #1549

Merged
merged 6 commits into from Jul 3, 2023
Merged

e2e #1549

merged 6 commits into from Jul 3, 2023

Conversation

abernier
Copy link
Contributor

@abernier abernier commented Jun 30, 2023

Why / What

This PR aims at testing the "real" built drei package against different environments: vite, cra, next, ... etc

yarn test script:

  1. builds the package
  2. for each environment:
    1. starts the same r3f App.jsx
    2. takes a puppeteer screenshot

The generated snapshot is supposed to be the same for all environments, so the script succeeds.

Checklist

  • Documentation updated (example)
  • Storybook entry added (example)
  • Ready to be merged

@vercel
Copy link

vercel bot commented Jun 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
drei ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2023 10:05pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 30, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ece3460:

Sandbox Source
green-dust-sfvg6q Configuration
Ground reflections and video textures Configuration
arc-x-pmndrs-colors Configuration

@drcmda drcmda merged commit e4897c9 into master Jul 3, 2023
4 checks passed
@github-actions
Copy link

github-actions bot commented Jul 4, 2023

🎉 This PR is included in version 9.78.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants