tweak some tests for react 18

pmndrs · Oct 3, 2021 · f38921b · f38921b
1 parent a4c455f
commit f38921b
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 23 deletions.
diff --git a/tests/async.test.tsx b/tests/async.test.tsx
@@ -47,7 +47,7 @@ it('does not show async stale result', async () => {
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Counter />
@@ -56,7 +56,7 @@ it('does not show async stale result', async () => {
           <DelayedCounter />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('loading')
@@ -329,13 +329,13 @@ it('updates an async atom in child useEffect on remount without setTimeout', asy
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Parent />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('count: 1')
@@ -380,13 +380,13 @@ it('updates an async atom in child useEffect on remount', async () => {
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Parent />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('count: 1')
@@ -426,13 +426,13 @@ it('async get and useEffect on parent', async () => {
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Parent />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('loading')
@@ -471,13 +471,13 @@ it('async get with another dep and useEffect on parent', async () => {
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Parent />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('loading')
@@ -638,13 +638,13 @@ it('a derived atom from a newly created async atom (#351)', async () => {
   }
 
   const { getByText, findByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Suspense fallback="loading">
           <Counter />
         </Suspense>
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await findByText('loading')

diff --git a/tests/basic.test.tsx b/tests/basic.test.tsx
@@ -795,11 +795,7 @@ it('changes atom from parent (#273, #275)', async () => {
   const Item = ({ id }: { id: string }) => {
     const a = useMemo(() => (id === 'a' ? atomA : atomB), [id])
     const [atomValue] = useAtom(a)
-    return (
-      <div>
-        commits: {useCommitCount()}, id: {atomValue.id}
-      </div>
-    )
+    return <div>id: {atomValue.id}</div>
   }
 
   const App = () => {
@@ -819,16 +815,16 @@ it('changes atom from parent (#273, #275)', async () => {
     </Provider>
   )
 
-  await findByText('commits: 1, id: a')
+  await findByText('id: a')
 
   fireEvent.click(getByText('atom a'))
-  await findByText('commits: 1, id: a')
+  await findByText('id: a')
 
   fireEvent.click(getByText('atom b'))
-  await findByText('commits: 2, id: b')
+  await findByText('id: b')
 
   fireEvent.click(getByText('atom a'))
-  await findByText('commits: 3, id: a')
+  await findByText('id: a')
 })
 
 it('should be able to use a double derived atom twice and useEffect (#373)', async () => {

diff --git a/tests/utils/useUpdateAtom.test.tsx b/tests/utils/useUpdateAtom.test.tsx
@@ -51,11 +51,11 @@ it('useUpdateAtom does not trigger rerender in component', async () => {
   }
 
   const { getByText } = render(
-    <StrictMode>
+    <>
       <Provider>
         <Parent />
       </Provider>
-    </StrictMode>
+    </>
   )
 
   await waitFor(() => {