fix(tests): add memory leak tests #2508
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/AKP2G9FBC |
See documentations for usage instructions.
|
Thanks, I will have a closer look later, but:
So, it means this doesn't reveal the regression with |
|
yeah, it seems to be already a problem in main |
tests/vanilla/memoryleaks.test.ts
Outdated
| ;(() => { | ||
| const objAtom = atom({}) | ||
| detector = new LeakDetector(store.get(objAtom)) | ||
| })() |
There was a problem hiding this comment.
Hm, I somehow thought function closure would be necessary, but I think I got something wrong. Let me update my PR.
|
Hi, I updated the main branch. Would you please pull it and adjust this PR so that the diff becomes minimal? |
|
Fixed by #2533 |
Related Issues or Discussions
#2477
Summary
Fails with store and store2