Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: memory leaks in store2 #2533

Merged
merged 12 commits into from
May 8, 2024
Merged

fix: memory leaks in store2 #2533

merged 12 commits into from
May 8, 2024

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Apr 30, 2024

close #2477

  • store2: reproduce the problem in tests
  • store2: refactor to avoid .s
  • store2: move "dependents" set into Mounted (like store.ts)
  • store2: see if it can be refactored more for readability

Copy link

vercel bot commented Apr 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
jotai ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:27am

Copy link

codesandbox-ci bot commented Apr 30, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

github-actions bot commented Apr 30, 2024

Size Change: +1.13 kB (+1%)

Total Size: 91.3 kB

Filename Size Change
dist/experimental.js 4.57 kB +281 B (+7%) 🔍
dist/system/experimental.development.js 3.72 kB +311 B (+9%) 🔍
dist/system/experimental.production.js 2.03 kB +140 B (+7%) 🔍
dist/umd/experimental.development.js 4.66 kB +281 B (+6%) 🔍
dist/umd/experimental.production.js 2.68 kB +121 B (+5%) 🔍
ℹ️ View Unchanged
Filename Size
dist/babel/plugin-debug-label.js 927 B
dist/babel/plugin-react-refresh.js 1.14 kB
dist/babel/preset.js 1.4 kB
dist/index.js 242 B
dist/react.js 1.06 kB
dist/react/utils.js 1.42 kB
dist/system/babel/plugin-debug-label.development.js 1.1 kB
dist/system/babel/plugin-debug-label.production.js 771 B
dist/system/babel/plugin-react-refresh.development.js 1.29 kB
dist/system/babel/plugin-react-refresh.production.js 929 B
dist/system/babel/preset.development.js 1.58 kB
dist/system/babel/preset.production.js 1.14 kB
dist/system/index.development.js 253 B
dist/system/index.production.js 182 B
dist/system/react.development.js 1.18 kB
dist/system/react.production.js 711 B
dist/system/react/utils.development.js 860 B
dist/system/react/utils.production.js 461 B
dist/system/utils.development.js 258 B
dist/system/utils.production.js 188 B
dist/system/vanilla.development.js 4.31 kB
dist/system/vanilla.production.js 2.17 kB
dist/system/vanilla/utils.development.js 5.08 kB
dist/system/vanilla/utils.production.js 3.07 kB
dist/umd/babel/plugin-debug-label.development.js 1.08 kB
dist/umd/babel/plugin-debug-label.production.js 855 B
dist/umd/babel/plugin-react-refresh.development.js 1.28 kB
dist/umd/babel/plugin-react-refresh.production.js 1.01 kB
dist/umd/babel/preset.development.js 1.54 kB
dist/umd/babel/preset.production.js 1.22 kB
dist/umd/index.development.js 381 B
dist/umd/index.production.js 329 B
dist/umd/react.development.js 1.18 kB
dist/umd/react.production.js 785 B
dist/umd/react/utils.development.js 1.55 kB
dist/umd/react/utils.production.js 1.03 kB
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 343 B
dist/umd/vanilla.development.js 5.19 kB
dist/umd/vanilla.production.js 2.79 kB
dist/umd/vanilla/utils.development.js 5.99 kB
dist/umd/vanilla/utils.production.js 3.71 kB
dist/utils.js 246 B
dist/vanilla.js 5.1 kB
dist/vanilla/utils.js 5.86 kB

compressed-size-action

Copy link

github-actions bot commented Apr 30, 2024

LiveCodes Preview in LiveCodes

Latest commit: e51777b
Last updated: May 8, 2024 2:27am (UTC)

Playground Link
React demo https://livecodes.io?x=id/5B5AFPBP4

See documentations for usage instructions.

@dai-shi dai-shi marked this pull request as ready for review May 7, 2024 12:55
@dai-shi dai-shi merged commit 9d5c4c0 into main May 8, 2024
37 checks passed
@dai-shi dai-shi deleted the fix/memory-leaks-in-store2 branch May 8, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and fix possible memory leaks in store2
1 participant