fix: harden hooks tests

pmndrs · Feb 27, 2023 · b22c406 · b22c406
1 parent 2847837
commit b22c406
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/packages/fiber/src/core/hooks.tsx b/packages/fiber/src/core/hooks.tsx
@@ -82,7 +82,7 @@ export interface Loader<T> extends THREE.Loader {
     onLoad?: (result: T, ...args: any[]) => void,
     onProgress?: (event: ProgressEvent) => void,
     onError?: (event: ErrorEvent) => void,
-  ): any
+  ): unknown
 }
 
 export type LoaderProto<T> = new (...args: any[]) => Loader<T>

diff --git a/packages/fiber/tests/hooks.test.tsx b/packages/fiber/tests/hooks.test.tsx
@@ -149,12 +149,14 @@ describe('hooks', () => {
 
   it('can handle useLoader with a loader extension', async () => {
     class Loader extends THREE.Loader {
-      load = (_url: string) => null
+      load(_url: string, onLoad: (result: null) => void): void {
+        onLoad(null)
+      }
     }
 
     let proto!: Loader
 
-    function Test() {
+    function Test(): null {
       return useLoader(Loader, '', (loader) => (proto = loader))
     }
     await act(async () => root.render(<Test />))