Vertices not updating

[martwz]

Hi, 👋

first of all I really enjoy playing around with react-three-fiber and I've even started to write my own thin wrapper around another library using react-three-fiber's reconciler 🎉.

While playing around with react-three-fiber I've found that my vertices are not updating, that might be an Three.js issue.

Here's a quick example, the button 'Add vertex' dynamically adds a new Vertex on each click, and applyProps gets properly called, but in the end the vertices are not updated: https://codesandbox.io/s/qqq7qpqvo9

[drcmda]

Looks odd indeed. I logged the geometry, the vectors are in there. Mutating works, too: https://codesandbox.io/s/m74413rlq8 Could be that the size of the vertices isn't supposed to change in three?

[drcmda]

Sorry, looks like it's confirmed: https://stackoverflow.com/questions/14840026/dynamically-adding-vertices-to-a-line-in-three-js

You can only update content of buffers, you cannot resize buffers (this is very costly, basically equivalent to creating new geometry).
You can emulate resizing by pre-allocating a larger buffer and then keeping unneeded vertices collapsed / hidden.

[martwz]

@drcmda thanks for looking into this, I think it can be closed then.

I've seen that you closed this issue and then reopened shortly after, was the reopening a mistake?

[drcmda]

yep, clicked the wrong button, just didn't want to close preemptively.