experiment: test React 19 with v8 #3239
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 16e4285:
|
packages/fiber/src/core/renderer.ts
Outdated
| finalizeInitialChildren(instance) { | ||
| const localState = instance?.__r3f ?? {} | ||
| // https://github.com/facebook/react/issues/20271 | ||
| // Returning true will trigger commitMount | ||
| return Boolean(localState.handlers) | ||
| }, | ||
| prepareUpdate(instance, _type, oldProps, newProps) { | ||
| const localState = instance?.__r3f ?? {} | ||
| commitUpdate(instance, _diff, type, oldProps, newProps, fiber) { |
There was a problem hiding this comment.
I'll check if we shouldn't change the signature of commitUpdate to commitUpdate(instance, type, oldProps, newProps, fiber) now. That may have helped recognizing earlier that _diff is always null now.
There was a problem hiding this comment.
Signature will have changed in the Beta release of the reconciler: facebook/react#28909
There was a problem hiding this comment.
Probably also helpful to diff packages/react-reconciler/README.md for the versions you're changing. We updated the readme so there might be other signature changes that were missed.
|
Thanks. Continuing in #3224 against v9 in alpha until we solidify our API over the next week. |
Mirrors #3224 against v8 for upstream integration testing. These changes will land in the v9 release.