Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vanilla): console warn instead of throwing in DEV #249

Merged
merged 2 commits into from
Oct 18, 2021
Merged

fix(vanilla): console warn instead of throwing in DEV #249

merged 2 commits into from
Oct 18, 2021

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 7, 2021

close #248

@github-actions
Copy link

github-actions bot commented Oct 7, 2021 •
edited
Loading

Size Change: +10 B (0%)

Total Size: 13.8 kB

Filename Size Change
dist/esm/vanilla.js 1.73 kB +4 B (0%)
dist/vanilla.js 1.85 kB +6 B (0%)
ℹ️ View Unchanged
Filename Size
dist/esm/index.js 1.33 kB
dist/esm/macro.js 613 B
dist/esm/utils.js 2.78 kB
dist/index.js 1.43 kB
dist/macro.js 916 B
dist/utils.js 3.11 kB

compressed-size-action

Aslemammad
Aslemammad reviewed Oct 7, 2021
View reviewed changes
src/vanilla.ts
}
return proxyObject[VERSION]
}
export const getVersion = (proxyObject: any): number => proxyObject[VERSION]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a better solution!

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9dbec05:

Sandbox Source
React Configuration
React Typescript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@dai-shi dai-shi merged commit 446a6ea into main Oct 18, 2021
@dai-shi dai-shi deleted the fix/issue-248 branch October 18, 2021 11:36
@dai-shi dai-shi mentioned this pull request Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Aslemammad Aslemammad Aslemammad left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not throw new Error('Please use proxy object') in DEV, but just console.warn
2 participants
@dai-shi @Aslemammad