Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): avoid Maximum call stack size exceeded error with circular structure #379

Merged
merged 8 commits into from
Feb 28, 2022

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Feb 22, 2022

@vercel
Copy link

vercel bot commented Feb 22, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/valtio/84HNDV5Xjtgu745p1w4FAw7EhbPS
✅ Preview: https://valtio-git-fix-issue-375-pmndrs.vercel.app

@github-actions
Copy link

github-actions bot commented Feb 22, 2022

Size Change: 0 B

Total Size: 45.7 kB

ℹ️ View Unchanged
Filename Size
dist/esm/index.js 1.36 kB
dist/esm/macro.js 613 B
dist/esm/utils.js 3.91 kB
dist/esm/vanilla.js 1.85 kB
dist/index.js 1.44 kB
dist/macro.js 910 B
dist/system/index.development.js 1.55 kB
dist/system/index.production.js 874 B
dist/system/macro.development.js 721 B
dist/system/macro.production.js 556 B
dist/system/utils.development.js 4.12 kB
dist/system/utils.production.js 2.75 kB
dist/system/vanilla.development.js 1.97 kB
dist/system/vanilla.production.js 1.25 kB
dist/umd/index.development.js 1.55 kB
dist/umd/index.production.js 990 B
dist/umd/macro.development.js 1.06 kB
dist/umd/macro.production.js 766 B
dist/umd/utils.development.js 4.66 kB
dist/umd/utils.production.js 2.95 kB
dist/umd/vanilla.development.js 2.06 kB
dist/umd/vanilla.production.js 1.31 kB
dist/utils.js 4.53 kB
dist/vanilla.js 1.95 kB

compressed-size-action

@dai-shi dai-shi changed the title add failing test for #375 fix: avoid Maximum call stack size exceeded error with circular structure Feb 22, 2022
@dai-shi dai-shi changed the title fix: avoid Maximum call stack size exceeded error with circular structure fix(core): avoid Maximum call stack size exceeded error with circular structure Feb 22, 2022
@dai-shi dai-shi marked this pull request as ready for review February 28, 2022 06:59
@dai-shi dai-shi merged commit 0a66c8f into main Feb 28, 2022
@dai-shi dai-shi deleted the fix/issue-375 branch February 28, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded error when using valtio with classes and propery getters
1 participant