feat(macro): macro for vite #386

Aslemammad · 2022-03-06T19:14:41Z

Resolves #299

vercel · 2022-03-06T19:14:46Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/pmndrs/valtio/HQdZweX8wfZfk67vUsFYq56FokLJ
✅ Preview: https://valtio-git-fork-aslemammad-feat-vite-macro-pmndrs.vercel.app

codesandbox-ci · 2022-03-06T19:15:12Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0588310:

Sandbox	Source
React	Configuration
React Typescript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration

.github/workflows/test-multiple-versions.yml

dai-shi · 2022-03-07T00:21:06Z

rollup.config.js

@@ -162,9 +162,13 @@ export default function (args) {
  let c = Object.keys(args).find((key) => key.startsWith('config-'))
  if (c) {
    c = c.slice('config-'.length).replace(/_/g, '/')
+    if (c === 'macro-vite') {


Doesn't config-macro_vite work??

I'll try that (I'm having some issues with types/exports, when importing valtio/macro/vite)

I mean L164 does the conversion, no?

oh, I thought you mean the cli command? yea, it does! in the end, it's valtio/macro/vite.js

Please remove L165-L167,

remove L171 empty line to to remove the changes in this file.

dai-shi

small change request

dai-shi · 2022-03-14T00:04:45Z

rollup.config.js

@@ -162,9 +162,13 @@ export default function (args) {
  let c = Object.keys(args).find((key) => key.startsWith('config-'))
  if (c) {
    c = c.slice('config-'.length).replace(/_/g, '/')
+    if (c === 'macro-vite') {


Please remove L165-L167,

package.json

dai-shi · 2022-03-14T00:06:40Z

rollup.config.js

@@ -162,9 +162,13 @@ export default function (args) {
  let c = Object.keys(args).find((key) => key.startsWith('config-'))
  if (c) {
    c = c.slice('config-'.length).replace(/_/g, '/')
+    if (c === 'macro-vite') {


remove L171 empty line to to remove the changes in this file.

dai-shi · 2022-03-14T00:07:22Z

website/.eslintrc.json

-  "root": true,
-  "extends": "next/core-web-vitals"


we shouldn't remove this, right??

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

dai-shi

Looks cool! We have undocumented convention of specifying versions. Please see comments.

package.json

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

dai-shi

Looks good now.

readme.md

Kaijun · 2022-10-09T06:50:54Z

Hi @Aslemammad

it seems aslemammad-vite-plugin-macro@1.0.0-alpha.1 is not compatible with vite@3.x

could you please upgrade vite peer dep verison for the macro plugin?

npm ERR! While resolving: aslemammad-vite-plugin-macro@1.0.0-alpha.1
npm ERR! Found: vite@3.0.6
npm ERR! node_modules/vite
npm ERR!   dev vite@"^3.0.6" from the root project
npm ERR!   peer vite@"^3.0.0" from @vitejs/plugin-react@2.0.1
npm ERR!   node_modules/@vitejs/plugin-react
npm ERR!     dev @vitejs/plugin-react@"^2.0.1" from the root project
npm ERR!   2 more (valtio, vite-plugin-dts)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer vite@"^2.3.0" from aslemammad-vite-plugin-macro@1.0.0-alpha.1
npm ERR! node_modules/aslemammad-vite-plugin-macro
npm ERR!   dev aslemammad-vite-plugin-macro@"^1.0.0-alpha.1" from the root project
npm ERR!   peerOptional aslemammad-vite-plugin-macro@">=1.0.0-alpha.1" from valtio@1.7.0
npm ERR!   node_modules/valtio
npm ERR!     valtio@"^1.7.0" from the root project

Aslemammad · 2022-10-18T13:52:47Z

I released v1.0.0, I think it would work now. @Kaijun

feat: init

2cd2549

vercel bot deployed to Preview March 6, 2022 19:14 View deployment

remove unused

0a01569

Aslemammad added 3 commits March 6, 2022 23:16

feat: use unreleased code

c80b38b

update package.json

13189af

relint

b88f637

vercel bot deployed to Preview March 6, 2022 19:48 View deployment

use node 14 for github actions

70be59b

vercel bot deployed to Preview March 6, 2022 20:36 View deployment

add macro-vite to build

9853d38

vercel bot deployed to Preview March 6, 2022 20:56 View deployment

add chokidar

40b2533

vercel bot deployed to Preview March 6, 2022 20:59 View deployment

relint

f410386

vercel bot deployed to Preview March 6, 2022 21:05 View deployment

macro vite in exports

978ed75

vercel bot deployed to Preview March 6, 2022 21:28 View deployment

dai-shi reviewed Mar 7, 2022

View reviewed changes

.github/workflows/test-multiple-versions.yml Show resolved Hide resolved

dai-shi reviewed Mar 7, 2022

View reviewed changes

use aslemammad-vite-plugin-macro

7f16d74

vercel bot deployed to Preview March 13, 2022 09:18 View deployment

lint

53638ee

vercel bot deployed to Preview March 13, 2022 09:20 View deployment

add readme

e46d1b1

vercel bot deployed to Preview March 13, 2022 10:19 View deployment

dai-shi requested changes Mar 14, 2022

View reviewed changes

Update package.json

cfde197

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

vercel bot had a problem deploying to Preview March 14, 2022 00:16 Failure

remove skipLibCheck

4a0ad46

vercel bot deployed to Preview March 15, 2022 18:34 View deployment

update yarn lock

3a8779e

vercel bot deployed to Preview March 15, 2022 18:35 View deployment

add ts-ignore

0bb36a2

vercel bot deployed to Preview March 15, 2022 18:38 View deployment

add eslint comment

385f581

vercel bot deployed to Preview March 15, 2022 18:40 View deployment

revert

cad1453

vercel bot deployed to Preview March 15, 2022 18:42 View deployment

patch

faec07f

vercel bot deployed to Preview March 15, 2022 20:46 View deployment

dai-shi requested changes Mar 15, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

Update package.json

5a3f72e

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

vercel bot deployed to Preview March 15, 2022 23:11 View deployment

Aslemammad and others added 2 commits March 16, 2022 02:41

Update package.json

6d3387e

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

Update package.json

417a13b

Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>

vercel bot deployed to Preview March 15, 2022 23:13 View deployment

update lock

2a40e21

vercel bot deployed to Preview March 15, 2022 23:19 View deployment

add postinstall

68220ea

vercel bot deployed to Preview March 15, 2022 23:30 View deployment

remove chokidar

0588310

vercel bot deployed to Preview March 15, 2022 23:42 View deployment

dai-shi approved these changes Mar 15, 2022

View reviewed changes

dai-shi reviewed Mar 15, 2022

View reviewed changes

readme.md Show resolved Hide resolved

dai-shi merged commit 0fcb5aa into pmndrs:main Mar 15, 2022

dai-shi changed the title ~~feat: macro for vite~~ feat(macro): macro for vite Mar 15, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(macro): macro for vite #386

feat(macro): macro for vite #386

Aslemammad commented Mar 6, 2022

vercel bot commented Mar 6, 2022 •

edited

Loading

codesandbox-ci bot commented Mar 6, 2022 •

edited

Loading

dai-shi Mar 7, 2022

Aslemammad Mar 7, 2022

dai-shi Mar 7, 2022

Aslemammad Mar 7, 2022 •

edited

Loading

dai-shi Mar 14, 2022

dai-shi Mar 14, 2022

dai-shi left a comment

dai-shi Mar 14, 2022

dai-shi Mar 14, 2022

dai-shi Mar 14, 2022

dai-shi left a comment

dai-shi left a comment

Kaijun commented Oct 9, 2022

Aslemammad commented Oct 18, 2022

feat(macro): macro for vite #386

feat(macro): macro for vite #386

Conversation

Aslemammad commented Mar 6, 2022

vercel bot commented Mar 6, 2022 • edited Loading

codesandbox-ci bot commented Mar 6, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Aslemammad Mar 7, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dai-shi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dai-shi left a comment

Choose a reason for hiding this comment

dai-shi left a comment

Choose a reason for hiding this comment

Kaijun commented Oct 9, 2022

Aslemammad commented Oct 18, 2022

vercel bot commented Mar 6, 2022 •

edited

Loading

codesandbox-ci bot commented Mar 6, 2022 •

edited

Loading

Aslemammad Mar 7, 2022 •

edited

Loading