Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: prefer object getters to derive util #798

Merged
merged 2 commits into from
Oct 22, 2023
Merged

Conversation

dai-shi
Copy link
Member

@dai-shi dai-shi commented Oct 16, 2023

Related Issues or Discussions

#792

Summary

This is to move forward the discussion, removing derive from some docs.

To: @stephenh @alexander-entin and maybe others
I have been avoiding to push this usage in getters, but I change my mind. Sorry about the change, and feedback/correction are welcome.

Check List

  • yarn run prettier for formatting code and docs

@vercel
Copy link

vercel bot commented Oct 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2023 2:16am

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 16, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 39dabf0:

Sandbox Source
React Configuration
React TypeScript Configuration
React Browserify Configuration
React Snowpack Configuration
React Parcel Configuration

@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Size Change: 0 B

Total Size: 57.2 kB

ℹ️ View Unchanged
Filename Size
dist/esm/index.js 62 B
dist/esm/macro.js 698 B
dist/esm/macro/vite.js 864 B
dist/esm/react.js 732 B
dist/esm/react/utils.js 225 B
dist/esm/utils.js 68 B
dist/esm/vanilla.js 2.42 kB
dist/esm/vanilla/utils.js 4.28 kB
dist/index.js 243 B
dist/macro.js 918 B
dist/macro/vite.js 1.08 kB
dist/react.js 668 B
dist/react/utils.js 244 B
dist/system/index.development.js 236 B
dist/system/index.production.js 170 B
dist/system/macro.development.js 779 B
dist/system/macro.production.js 556 B
dist/system/macro/vite.development.js 951 B
dist/system/macro/vite.production.js 660 B
dist/system/react.development.js 871 B
dist/system/react.production.js 471 B
dist/system/react/utils.development.js 321 B
dist/system/react/utils.production.js 223 B
dist/system/utils.development.js 241 B
dist/system/utils.production.js 176 B
dist/system/vanilla.development.js 2.57 kB
dist/system/vanilla.production.js 1.51 kB
dist/system/vanilla/utils.development.js 4.5 kB
dist/system/vanilla/utils.production.js 2.9 kB
dist/umd/index.development.js 382 B
dist/umd/index.production.js 330 B
dist/umd/macro.development.js 1.04 kB
dist/umd/macro.production.js 721 B
dist/umd/macro/vite.development.js 1.23 kB
dist/umd/macro/vite.production.js 879 B
dist/umd/react.development.js 814 B
dist/umd/react.production.js 526 B
dist/umd/react/utils.development.js 400 B
dist/umd/react/utils.production.js 299 B
dist/umd/utils.development.js 398 B
dist/umd/utils.production.js 344 B
dist/umd/vanilla.development.js 2.73 kB
dist/umd/vanilla.production.js 1.63 kB
dist/umd/vanilla/utils.development.js 5.04 kB
dist/umd/vanilla/utils.production.js 3.13 kB
dist/utils.js 247 B
dist/vanilla.js 2.61 kB
dist/vanilla/utils.js 4.87 kB

compressed-size-action

@dai-shi dai-shi merged commit 5f37b80 into main Oct 22, 2023
33 checks passed
@dai-shi dai-shi deleted the docs/prefer-object-getters branch October 22, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant