refactor!: deprecate proxyWithHistory #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds reference to new npm package and codesandbox demo
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a9f734d:
|
|
How about adding console warning to force migrating? valtio/src/vanilla/utils/proxyWithComputed.ts Lines 23 to 27 in 58f17ba |
lwhiteley
force-pushed
the
proxy-with-history-updates
branch
from
ae4da51
to
a9f734d
Compare
|
updated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues or Discussions
Summary
Move
proxyWithHistoryto thevaltio-historypackageThis includes an api change for the utility function.
The
proxyWithHistoryutility withinvaltio/utilsis now marked as deprecated.BREAKING CHANGE:
see valtio-history for change notes and migration guide