chore(tests): add simple tests for ref rerender and subscription #88
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 086283a:
|
| await findByText('count: 0') | ||
|
|
||
| fireEvent.click(getByText('button')) | ||
| await findByText('count: 0') |
There was a problem hiding this comment.
I guess this check is weak. It doesn't guarantee that the count keeps 0, does it?
There was a problem hiding this comment.
can you double check if this fails if you remove ref? I might be wrong though.
There was a problem hiding this comment.
yeah, it does still pass without ref 🤔 what would be your recommendation here to make the test stronger?
There was a problem hiding this comment.
added the wait for the Promise.resolve to make the assertion of findByText wait for the changes to be flushed. now it fails with no ref 😀
no ref - count: 0 - count: 0 -> FAIL
no ref - count: 0 - count: 1 -> PASS
ref - count: 0 - count: 0 -> PASS
ref - count: 0 - count: 1 -> FAIL
There was a problem hiding this comment.
Yeah, I wasn't so sure about the best way.
Promise.resolve() is a nice hack, even though it depends on some implementation details. We are doing it in other tests, anyway.
Good to go. And hope someone has a better idea in the future.
There was a problem hiding this comment.
Yeah, thanks! i'll see if theres a better solution and update this and the other tests! 👍
| obj.nested.count += 1 | ||
|
|
||
| await Promise.resolve() | ||
| expect(handler).toBeCalledTimes(0) |
| await findByText('count: 0') | ||
|
|
||
| fireEvent.click(getByText('button')) | ||
| await findByText('count: 0') |
There was a problem hiding this comment.
Yeah, I wasn't so sure about the best way.
Promise.resolve() is a nice hack, even though it depends on some implementation details. We are doing it in other tests, anyway.
Good to go. And hope someone has a better idea in the future.
Adds some simple tests for
refthat was introduced in #62 and #65 fixes #66