Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add react compiler eslint rules #908

Merged
merged 3 commits into from
Jun 21, 2024
Merged

chore: add react compiler eslint rules #908

merged 3 commits into from
Jun 21, 2024

Conversation

L-Qun
Copy link
Contributor

@L-Qun L-Qun commented Jun 6, 2024

Summary

If we want better support for the React Compiler, adding eslint-plugin-react-compiler might be a good choice, I think.

Check List

  • yarn run prettier for formatting code and docs

Copy link

vercel bot commented Jun 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
valtio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 2:06pm

Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codesandbox-ci bot commented Jun 6, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Jun 20, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

commit: 479416a

valtio

npm i https://pkg.pr.new/valtio@908


templates

@dai-shi
Copy link
Member

dai-shi commented Jun 21, 2024

Thanks for the suggestion.
Can you open PRs to zustand and jotai too?
We try to keep the same eslint config among the three.

@L-Qun
Copy link
Contributor Author

L-Qun commented Jun 21, 2024

Thanks for the suggestion. Can you open PRs to zustand and jotai too? We try to keep the same eslint config among the three.

@dai-shi Done

@L-Qun
Copy link
Contributor Author

L-Qun commented Jun 21, 2024

Thanks for the suggestion. Can you open PRs to zustand and jotai too? We try to keep the same eslint config among the three.

@dai-shi Done

@dai-shi 😊 Please let me know if there is anything else I need to do

Copy link
Member

@dai-shi dai-shi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@dai-shi dai-shi merged commit a22a953 into pmndrs:main Jun 21, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants