Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vanilla): unexpected null state update behavior #2213

Merged
merged 3 commits into from
Nov 27, 2023
Merged

fix(vanilla): unexpected null state update behavior #2213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7ced7ec
fix: unexpected null state update behavior
wulimao49 Nov 25, 2023
42ac8ee
chore: lint code
Nov 26, 2023
63d1e81
test: add test for setting state to null
Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/vanilla.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ const createStoreImpl: CreateStoreImpl = (createState) => {
if (!Object.is(nextState, state)) {
const previousState = state
state =
replace ?? typeof nextState !== 'object'
replace ?? (typeof nextState !== 'object' || nextState === null)
dai-shi marked this conversation as resolved.
Show resolved Hide resolved
? (nextState as TState)
: Object.assign({}, state, nextState)
listeners.forEach((listener) => listener(state, previousState))
Expand Down
18 changes: 18 additions & 0 deletions tests/vanilla/basic.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,24 @@ it('can set the store without merging', () => {
expect(getState()).toEqual({ b: 2 })
})

it('can set the object store to null', () => {
const { setState, getState } = createStore<{ a: number } | null>(() => ({
a: 1,
}))

setState(null)

expect(getState()).toEqual(null)
})

it('can set the non-object store to null', () => {
const { setState, getState } = createStore<string | null>(() => 'value')

setState(null)

expect(getState()).toEqual(null)
})

it('works with non-object state', () => {
const store = createStore<number>(() => 1)
const inc = () => store.setState((c) => c + 1)
Expand Down