fix(vanilla): unexpected null state update behavior #2213

wulimao49 · 2023-11-25T08:26:44Z

unexpected behavior when update state with [null]

the code above will cause something like

const useStore = create<string | null>(() => 'default');

useStore.setState(null); // will actually run: Object.assign({}, 'default', null)

useStore.getState(); // get { "0": "d", "1": "e", "2": "f", "3": "a", "4": "u", "5": "l",  "6": "t" }

vercel · 2023-11-25T08:26:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
zustand-demo	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 27, 2023 2:26am

codesandbox-ci · 2023-11-25T08:27:13Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63d1e81:

Sandbox	Source
React	Configuration
React TypeScript	Configuration
React Browserify	Configuration
React Snowpack	Configuration
React Parcel	Configuration
Next.js	Configuration
@pavlobu/zustand demo	Configuration

dai-shi

Please check CI errors.

src/vanilla.ts

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zustand](https://togithub.com/pmndrs/zustand) | [`4.4.6` -> `4.4.7`](https://renovatebot.com/diffs/npm/zustand/4.4.6/4.4.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/zustand (zustand)</summary> ### [`v4.4.7`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.7) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.6...v4.4.7) There's a small fix for a use case with an non-object value in store. #### What's Changed - fix(vanilla): unexpected null state update behavior by [@wulimao49](https://togithub.com/wulimao49) in [pmndrs/zustand#2213 #### New Contributors - [@isiagi](https://togithub.com/isiagi) made their first contribution in [pmndrs/zustand#2208 - [@ADTC](https://togithub.com/ADTC) made their first contribution in [pmndrs/zustand#2202 - [@wulimao49](https://togithub.com/wulimao49) made their first contribution in [pmndrs/zustand#2213 **Full Changelog**: pmndrs/zustand@v4.4.6...v4.4.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 3am,before 9am" (UTC), Automerge - "after 3am,before 9am" (UTC). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/ettorepuccetti/terrarossa).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zustand](https://togithub.com/pmndrs/zustand) | [`4.4.6` -> `4.4.7`](https://renovatebot.com/diffs/npm/zustand/4.4.6/4.4.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/zustand (zustand)</summary> ### [`v4.4.7`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.7) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.6...v4.4.7) There's a small fix for a use case with an non-object value in store. #### What's Changed - fix(vanilla): unexpected null state update behavior by [@wulimao49](https://togithub.com/wulimao49) in [pmndrs/zustand#2213 #### New Contributors - [@isiagi](https://togithub.com/isiagi) made their first contribution in [pmndrs/zustand#2208 - [@ADTC](https://togithub.com/ADTC) made their first contribution in [pmndrs/zustand#2202 - [@wulimao49](https://togithub.com/wulimao49) made their first contribution in [pmndrs/zustand#2213 **Full Changelog**: pmndrs/zustand@v4.4.6...v4.4.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SHABIN-K/toss).

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [zustand](https://togithub.com/pmndrs/zustand) | [`4.4.6` -> `4.4.7`](https://renovatebot.com/diffs/npm/zustand/4.4.6/4.4.7) | [![age](https://developer.mend.io/api/mc/badges/age/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/zustand/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/zustand/4.4.6/4.4.7?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>pmndrs/zustand (zustand)</summary> ### [`v4.4.7`](https://togithub.com/pmndrs/zustand/releases/tag/v4.4.7) [Compare Source](https://togithub.com/pmndrs/zustand/compare/v4.4.6...v4.4.7) There's a small fix for a use case with an non-object value in store. #### What's Changed - fix(vanilla): unexpected null state update behavior by [@wulimao49](https://togithub.com/wulimao49) in [pmndrs/zustand#2213 #### New Contributors - [@isiagi](https://togithub.com/isiagi) made their first contribution in [pmndrs/zustand#2208 - [@ADTC](https://togithub.com/ADTC) made their first contribution in [pmndrs/zustand#2202 - [@wulimao49](https://togithub.com/wulimao49) made their first contribution in [pmndrs/zustand#2213 **Full Changelog**: pmndrs/zustand@v4.4.6...v4.4.7 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 4pm every weekday" in timezone Europe/Paris, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/specfy/specfy).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fix: unexpected null state update behavior

7ced7ec

vercel bot deployed to Preview November 25, 2023 08:27 View deployment

dai-shi reviewed Nov 26, 2023

View reviewed changes

src/vanilla.ts Outdated Show resolved Hide resolved

dbritto-dev requested changes Nov 26, 2023

View reviewed changes

src/vanilla.ts Outdated Show resolved Hide resolved

chore: lint code

42ac8ee

vercel bot deployed to Preview November 26, 2023 11:39 View deployment

test: add test for setting state to null

63d1e81

vercel bot deployed to Preview November 27, 2023 02:26 View deployment

dai-shi reviewed Nov 27, 2023

View reviewed changes

src/vanilla.ts Show resolved Hide resolved

dai-shi approved these changes Nov 27, 2023

View reviewed changes

dbritto-dev approved these changes Nov 27, 2023

View reviewed changes

dai-shi changed the title ~~fix: unexpected null state update behavior~~ fix(vanilla): unexpected null state update behavior Nov 27, 2023

dai-shi added this to the v4.4.7 milestone Nov 27, 2023

dai-shi merged commit 949b505 into pmndrs:main Nov 27, 2023
35 checks passed

jonathanchisnyk mentioned this pull request Mar 29, 2024

[Snyk] Upgrade zustand from 4.4.1 to 4.5.2 JonChiAppRisk/juice-shop-goof#8

Open

JoeySnyk mentioned this pull request Apr 6, 2024

[Snyk] Upgrade zustand from 4.4.1 to 4.5.2 JoeySnyk/juice-shop-goof#5

Open

iuriikogan-snyk mentioned this pull request Apr 14, 2024

[Snyk] Upgrade zustand from 4.4.1 to 4.5.2 iuriikogan-snyk/juice-shop#11

Open

taylorbrownsnyk mentioned this pull request May 9, 2024

[Snyk] Upgrade zustand from 4.4.1 to 4.5.2 GHE-Test123/juice-shop-goof#5

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(vanilla): unexpected null state update behavior #2213

fix(vanilla): unexpected null state update behavior #2213

wulimao49 commented Nov 25, 2023

vercel bot commented Nov 25, 2023 •

edited

codesandbox-ci bot commented Nov 25, 2023 •

edited

dai-shi left a comment

fix(vanilla): unexpected null state update behavior #2213

fix(vanilla): unexpected null state update behavior #2213

Conversation

wulimao49 commented Nov 25, 2023

vercel bot commented Nov 25, 2023 • edited

codesandbox-ci bot commented Nov 25, 2023 • edited

dai-shi left a comment

Choose a reason for hiding this comment

vercel bot commented Nov 25, 2023 •

edited

codesandbox-ci bot commented Nov 25, 2023 •

edited