-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(middleware): devtools to patch api.setState with namedSet and fix middleware types #634
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 39d8e66:
|
Size Change: -18 B (0%) Total Size: 11.2 kB
ℹ️ View Unchanged
|
I guess I understand what was wrong. |
doesn't this end up adding the initial concern that we had about the function knowing something extra compared to others? I mean, |
Do you mean people can add custom store type without using its middleware? At least, if you use Most importantly, vanilla.ts doesn't know anything about middleware. |
The last point makes the change a valid decision. Still a bit on the complicated side since we've got a lot on inner extends that might get hard to control or understand over time. |
I don't disagree, it's complicated. |
close #517