Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lookup for referees whose names are missing #113

Closed
pmonks opened this issue Oct 23, 2020 · 2 comments
Closed

Add lookup for referees whose names are missing #113

pmonks opened this issue Oct 23, 2020 · 2 comments
Assignees
Labels
feature New feature, functionality or request functional Functional (i.e. user-visible) work wont MoSCoW - this WON'T be implemented

Comments

@pmonks
Copy link
Owner

pmonks commented Oct 23, 2020

Description of Problem:

When the football-data API returns a referee without a name, I want the bot to lookup up the name in a local directory (using the referee's id, as returned by the API), so I can see the referee's name instead of the default ([unnamed referee]).

Potential Solutions:

Add a map of referee-id → referee name to the config.edn, and use that map if and only if the API response is missing a name (i.e. the API always has precedence).

@pmonks pmonks added feature New feature, functionality or request functional Functional (i.e. user-visible) work should MoSCoW - this SHOULD be implemented labels Oct 23, 2020
@pmonks pmonks self-assigned this Oct 23, 2020
@pmonks
Copy link
Owner Author

pmonks commented Oct 23, 2020

The maintainer of football-data.org has indicated they've fixed this for some of the more prominent referees, and are looking into fixing some of the other missing names too, so I think this is lower priority now.

I'll leave it open for a bit until we've had a good chance to see the new data in action, and then we can make a call about whether to implement it or not.

@pmonks pmonks added could MoSCoW - this COULD be implemented and removed should MoSCoW - this SHOULD be implemented labels Oct 23, 2020
@pmonks
Copy link
Owner Author

pmonks commented May 2, 2021

The new data seems pretty good, and the maintainer of football-data.org is responsive to feedback, so I don't think this is necessary.

@pmonks pmonks closed this as completed May 2, 2021
@pmonks pmonks added wont MoSCoW - this WON'T be implemented and removed could MoSCoW - this COULD be implemented labels May 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature, functionality or request functional Functional (i.e. user-visible) work wont MoSCoW - this WON'T be implemented
Projects
None yet
Development

No branches or pull requests

1 participant