Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread barriers are not implemented in OS X #10

Closed
BohuTANG opened this issue Jan 24, 2016 · 6 comments
Closed

pthread barriers are not implemented in OS X #10

BohuTANG opened this issue Jan 24, 2016 · 6 comments
Assignees

Comments

@BohuTANG
Copy link
Contributor

@leo-yuriev
@pmwkaa

Ioarena is broken on OS X, errors are as follow:

src/ia.h:16:2: error: unknown type name 'pthread_barrier_t'
  pthread_barrier_t barrier_start;

Here is an implementation:
http://blog.albertarmea.com/post/47089939939/using-pthreadbarrier-on-mac-os-x

@erthink
Copy link
Collaborator

erthink commented Jan 24, 2016

Could someone check on a Mac ?

@BohuTANG
Copy link
Contributor Author

@leo-yuriev
Y.
Sophia & nessDB & others SEs is cross-platform compatible.
Most hackers prefer Macs.

@erthink
Copy link
Collaborator

erthink commented Jan 24, 2016

OK ;)

Please close issue if done.

@erthink
Copy link
Collaborator

erthink commented Feb 1, 2016

Could we close this issue and merge b8854d4 (the devel branch) into master ?

@BohuTANG
Copy link
Contributor Author

BohuTANG commented Feb 1, 2016

pthread_barrier_t is OK.
But still has problem with clock_gettime:

ioarena/src/ia_histogram.c:29:2: error: implicit declaration of function 'clock_gettime' [-Werror=implicit-function-declaration]
  int rc = clock_gettime(CLOCK_ID, &ts);
  ^
ioarena/src/ia_histogram.c:16:19: error: 'CLOCK_REALTIME' undeclared (first use in this function)
 # define CLOCK_ID CLOCK_REALTIME
                   ^
ioarena/src/ia_histogram.c:29:25: note: in expansion of macro 'CLOCK_ID'
  int rc = clock_gettime(CLOCK_ID, &ts);
                         ^

@erthink
Copy link
Collaborator

erthink commented Feb 1, 2016

I'm closing this issue, but added the #13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants