Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hebrew Language #324

Merged
merged 4 commits into from
Feb 15, 2022
Merged

Add Hebrew Language #324

merged 4 commits into from
Feb 15, 2022

Conversation

leranp
Copy link
Contributor

@leranp leranp commented Feb 11, 2022

No description provided.

@pndurette
Copy link
Owner

Oh nice find! However the language code for Hebrew looks to be iw so the tests are failing.
Do you mind adding it to the file, i.e.

     "it": "Italian",
+    "iw": "Hebrew",
     "ja": "Japanese",

Instead? Then I'll merge and carve a new release.
Thanks!

Sorry, my mistake, i didn't have time to check before commit :-)
@codecov
Copy link

codecov bot commented Feb 12, 2022

Codecov Report

Merging #324 (cb88d79) into master (b0990fc) will decrease coverage by 0.30%.
The diff coverage is 50.00%.

❗ Current head cb88d79 differs from pull request most recent head 3fff1ee. Consider uploading reports for the commit 3fff1ee to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##            master     #324      +/-   ##
===========================================
- Coverage   100.00%   99.69%   -0.31%     
===========================================
  Files           12       13       +1     
  Lines          325      326       +1     
===========================================
  Hits           325      325              
- Misses           0        1       +1     
Impacted Files Coverage Δ
gtts/accents.py 0.00% <0.00%> (ø)
gtts/langs.py 100.00% <ø> (ø)
gtts/tts.py 100.00% <ø> (ø)
gtts/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67962c...3fff1ee. Read the comment docs.

@leranp
Copy link
Contributor Author

leranp commented Feb 13, 2022

Please add this commit 👍

@pndurette pndurette merged commit 488df71 into pndurette:master Feb 15, 2022
@leranp
Copy link
Contributor Author

leranp commented Feb 15, 2022

@pndurette Thanks for the merged , can you please release a new version , i want to add it to Home Assistant

@pndurette
Copy link
Owner

Will do today! I see there's other new languages too, will release at once.

@pndurette
Copy link
Owner

@leranp Update—I didn't take the time unfortunately, I'm in the middle of a move, apologies about that! Before next week I should be able to.

@leranp
Copy link
Contributor Author

leranp commented Mar 8, 2022

@leranp Update—I didn't take the time unfortunately, I'm in the middle of a move, apologies about that! Before next week I should be able to.
Hi
any news about the new release ?

@Idan37S
Copy link

Idan37S commented Mar 13, 2022

Looking forward for the new release with this commit.
Any estimation on the release date?

@pndurette
Copy link
Owner

@leranp: thanks so much for your patience—
Released in gTTS 2.2.4! cc: @Idan37S

bmwiedemann referenced this pull request in bmwiedemann/openSUSE Mar 21, 2022
https://build.opensuse.org/request/show/963733
by user mcepl + dimstar_suse
- Make tests working at least a little bit. Requires two new patches:
  - demock.patch (gh#pndurette/gTTS#343)
  - network-tests.patch (gh#pndurette/gTTS#344)
- version update to 2.2.4
  2.2.4 (2022-03-14)
  ------------------
  Features
  ~~~~~~~
  - Added Malay language support (`#316 <https://github.com/pndurette/gTTS/issues/316>`_)
  - Added Hebrew language support (`#324 <https://github.com/pndurette/gTTS/issues/324>`_)
  - Added new ``gTTS.stream()`` method to stream bytes (`#319 <https://github.com/pndurette/gTTS/issues/319>`_)
  Misc
  ~~~
  - `#334 <https://github.com/pndurette/gTTS/issues/334>`_
  2.2.3 (2021-06-17)
  ------------------
  Features
  ~~~~~~~
  - Added Bulgarian language support (`#302 <https://github.com/pndurette/gTTS/issues/302>`_)
  2.2.2 (2021-02-03)
  --------
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants