Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavBar Behavior #10

Closed
Yaron10 opened this issue Mar 10, 2016 · 14 comments
Closed

NavBar Behavior #10

Yaron10 opened this issue Mar 10, 2016 · 14 comments
Labels

Comments

@Yaron10
Copy link

Yaron10 commented Mar 10, 2016

I think it's good to have a reference to this issue.

@pnedev
Copy link
Owner

pnedev commented Mar 10, 2016

Yes, indeed. Thanks.

@pnedev
Copy link
Owner

pnedev commented Mar 26, 2016

Hello Yaron,

This is fixed in master branch. NavBar can be further optimized but that is another matter.
Closing this now.

BR

@pnedev pnedev closed this as completed Mar 26, 2016
@Yaron10
Copy link
Author

Yaron10 commented Mar 26, 2016

Hello Pavel,

Great. Thank you.

I really don't know how the NavBar should work and display the overall diffs.
As for this issue: unchecking “Ignore Spacing” and comparing the files in Test.zip, I get a different image than both posted by Doutei. :)

Best regards.

@pnedev
Copy link
Owner

pnedev commented Mar 27, 2016

Hello Yaron,

Yes, there are still some issues. I'll check that.
Thanks.

BR

@pnedev pnedev reopened this Mar 27, 2016
@Yaron10
Copy link
Author

Yaron10 commented Mar 27, 2016

Thank you Pavel. I appreciate it.

BR

@pnedev
Copy link
Owner

pnedev commented Apr 6, 2016

Hello Yaron,

One a bit "strange" question - What is the resolution of your monitor?

The current NavBar looks exactly as the first image from Doutei if you have a vertical resolution greater than the number of lines in the compared documents (the bigger number from the two).
This is because each vertical pixel in the NavBar bitmap currently represents one line from the compare and if you have less vertical screen resolution than the compared lines some get overwritten.
This is a problem of course and as I said there are still some issues and things to be fixed. I just wanted to clarify :)

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 6, 2016

Hello Pavel,

Thank you for everything.
Just when we get to the interesting part (the Compares and layout handling; - not the NavBar) I hardly have a free minute.
Tomorrow I probably won't be by a PC. I'm looking forward to Friday. :)

My resolution is 1360x768.

The "Select First" is a truly brilliant idea.
How about "Compare current to last active"?

I'll elaborate on that and other issues.

Best regards.

@pnedev
Copy link
Owner

pnedev commented Apr 6, 2016

Hello Yaron,

Don't worry, we'll discuss things further when you have time, thanks.

How about "Compare current to last active"?

I see what you mean. That's interesting but I think it might get a bit confusing for the user and it will add another compare command to the plugin menu (which seems a bit too much).

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 8, 2016

Hello Pavel,

Some screenshots of the NavBar on my machine.

Thank you.

BR

NavBar.zip

@pnedev
Copy link
Owner

pnedev commented Apr 12, 2016

Thank you, I'll investigate it sometime in the future.

BR

@Yaron10
Copy link
Author

Yaron10 commented Apr 13, 2016

Great. Thank you.

BR

@pnedev pnedev added bug and removed question labels May 18, 2016
@pnedev
Copy link
Owner

pnedev commented Jun 20, 2016

Hello Yaron,

I've made a lot of modifications and optimizations to the NavBar and basically it should be functional and working OK now. There might still be some issues but nothing critical I hope. I'll clean them regularly as those pop-up, thanks.
I'm closing this issue now.

BR

@pnedev pnedev closed this as completed Jun 20, 2016
@Yaron10
Copy link
Author

Yaron10 commented Jun 20, 2016

Hello Pavel,

As you know I hardly use the NavBar.
Anyway - using Doutei's comment and images as a reference point, your work seems great as always. :)

Thank you very much.
BR

@pnedev
Copy link
Owner

pnedev commented Jun 21, 2016

Thanks Yaron.

BR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants