Skip to content

Commit

Permalink
WIP switch to GenerateIntoSlashTemp to test whether that fixes issu…
Browse files Browse the repository at this point in the history
…e when testing on CI.
  • Loading branch information
pnkfelix committed May 14, 2020
1 parent 34a1a2d commit 3e8a932
Showing 1 changed file with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion tests/common/which_temp.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,13 @@ pub trait WhichTempDirectory {
// Doing so has two drawbacks: 1. You need to clean-up the
// generated directory yourself, and 2. You risk race conditions with
// concurrent test runs.
pub(crate) type WhichTempDir /*: WhichTempDirectory*/ = GenerateIntoFreshTemp;
//
// If you cange this to `GenerateIntoFreshTemp`, you get a fresh directory
// (rooted at whatever is returned from `tempfile::tempdir()`). This reduces
// race conditions (note that `cargo-bisect-rustc` still stores data in shared
// locations like `~/.rustup`, so races can still arise) and allows the test
// suite to clean up the directory itself.
pub(crate) type WhichTempDir /*: WhichTempDirectory*/ = GenerateIntoSlashTemp;

/// Using `GenerateIntoFreshTemp` yields a fresh directory in some
/// system-dependent temporary space. This fresh directory will be autoamtically
Expand Down

0 comments on commit 3e8a932

Please sign in to comment.