Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCOPFLOW Functionality Tests failing with hiop@1.0.0 #3

Closed
3 of 4 tasks
jaelynlitz opened this issue Sep 13, 2023 · 4 comments · Fixed by #84
Closed
3 of 4 tasks

SCOPFLOW Functionality Tests failing with hiop@1.0.0 #3

jaelynlitz opened this issue Sep 13, 2023 · 4 comments · Fixed by #84

Comments

@jaelynlitz
Copy link
Contributor

jaelynlitz commented Sep 13, 2023

Issue type: Bug
Relates to:

  • SCOPFLOW
  • CMake build system
  • Spack configuration

Summary:

Incline CI fails on the following tests:
Failed Pipeline:
https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/jobs/125455
Raw Job output:
https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/jobs/125455/raw
The objective value and expected values are not within tolerance. Meaning we could increase tolerance or change the expected value for tests that run on Incline.
Things to further do:
Confirm Hiop version
Run Crusher test and compare objective values across platforms.
FUNCTIONALITY_TEST_SCOPFLOW_HIOP_PBHIOP_TESTSUITE is failing for Newell at the moment as well - https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/jobs/126069

Types of failures:

  • divide by zero (various tests and platforms, incline, deception, newell) (FUNCTIONALITY_TEST_SCOPFLOW_HIOP_PBHIOP_TESTSUITE, FUNCTIONALITY_TEST_SCOPFLOW_HIOP_SERIAL_TESTSUITE, FUNCTIONALITY_TEST_SCOPFLOW_HIOP_RAJA_TESTSUITE)
  • num iters (FUNCTIONALITY_TEST_SCOPFLOW_HIOP_MPI_TESTSUITE, incline)
  • obj value out of tolerance (FUNCTIONALITY_TEST_SCOPFLOW_EMPAR_CONT_TESTSUITE, incline)
  • timeout (FUNCTIONALITY_TEST_SOPFLOW_SCENARIO_RAJA_GPU_TOML, incline)
@cameronrutherford cameronrutherford changed the title SCOPFLOW Funtionality Tests failing with hiop@develop SCOPFLOW Funtionality Tests failing with hiop@develop Oct 2, 2023
@cameronrutherford
Copy link
Contributor

Does this close/reference a GitLab issue?

I think this is also just with hiop@1.0.0 since that is what is running in CI, and this is similar to #43

@jaelynlitz
Copy link
Contributor Author

This was me copying over issue#459 https://gitlab.pnnl.gov/exasgd/frameworks/exago/-/issues/459

@cameronrutherford cameronrutherford changed the title SCOPFLOW Funtionality Tests failing with hiop@develop SCOPFLOW Functionality Tests failing with hiop@1.0.0 Oct 13, 2023
@jaelynlitz jaelynlitz mentioned this issue Nov 21, 2023
20 tasks
@jaelynlitz
Copy link
Contributor Author

the only remaining failure on PNNL systems in SOPFLOW/SCOPFLOW with hiop@1.0.1 is the timeout on FUNCTIONALITY_TEST_SOPFLOW_SCENARIO_RAJA_GPU_TOML on incline https://gitlab.pnnl.gov/exasgd/frameworks/exago-github-mirror/-/jobs/138118#L88

@cameronrutherford
Copy link
Contributor

Same with #43 - if this is just incline, might be worth making a new issue for Incline specific issues and moving on for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants