Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert normal arrays to custom Vectors as they show order of magnitude improvement #13

Closed
LouisJenkinsCS opened this issue Sep 12, 2018 · 3 comments
Assignees

Comments

@LouisJenkinsCS
Copy link
Collaborator

LouisJenkinsCS commented Sep 12, 2018

The Vector implementation in Vector.chpl outperforms Chapel Array push_back by 10x and so we should see significant improvement once this conversion has completed.

Push-Back: 8.92253 seconds
Append: 0.91275 seconds
@LouisJenkinsCS LouisJenkinsCS self-assigned this Sep 12, 2018
@LouisJenkinsCS
Copy link
Collaborator Author

Also makes it possible to do the 1.5D arrays as the Vector can be parameterized on the domain which may or may not be distributed.

@LouisJenkinsCS
Copy link
Collaborator Author

A better way to do this, for the meantime at least, is to just implement vector logic for neighborList by having a separate counter (perhaps atomic so that it may be accessible without acquiring lock).

@github-actions
Copy link

This issue is stale and should either be closed or eventually resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant