Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Feature: Added support for sensitivity label while creating new site collections #2713

Merged

Conversation

gautamdsheth
Copy link
Contributor

Type

  • Bug Fix
  • New Feature
  • Sample

Related Issues?

Mentioned in #2699

What is in this Pull Request ?

This PR adds support for sensitivity labels while creating modern sites.

As mentioned in the below URL, it is dependent on core library where it has been merged.
pnp/PnP-Sites-Core#2668

A thing to note here, in case of modern communication sites, the labels appear instantly whereas in case of team sites, it takes couple of hours before they appear. If user wants to validate the label, they can go to the Azure portal and check the label value.

@KoenZomers
Copy link
Collaborator

I tested it and it doesn't work for me yet as it will use Microsoft Graph to create the site which does not yet support adding a sensitivity label. I have updated a PR I'm having open with PnP Sites Core making similar modifications to force the SharePoint API to be used whenever a sensitivitylabel has been provided: pnp/PnP-Sites-Core#2672

We'll need to wait for that to be merged before we can finalize testing this PR.

Another issue I have found is that if you're using a Graph Token, is that the GetGroupCreationContext does not succeed in retrieving the existing sensitivity labels on the tenant and thereby fails to assign the label to the site. When authenticating directly to SharePoint using i.e. -WebLogin, it does work fine. Don't see a solution for that issue, so leaving that as is.

@KoenZomers KoenZomers added status:checked and ready for merge ✔ PR has been checked and is ready for merge and removed status:Awaiting PnP Sites Core PR 🚧 Waiting for a PR in PnP Sites Core to be merged first labels Jun 8, 2020
@erwinvanhunen erwinvanhunen added Needs: Attention 👋 and removed status:checked and ready for merge ✔ PR has been checked and is ready for merge labels Jun 8, 2020
@erwinvanhunen
Copy link
Member

@gautamdsheth , due to a merge of an earlier PR, this PR is introducing some conflicts. Can you resolve them? Thanks!

@gautamdsheth
Copy link
Contributor Author

Hey @erwinvanhunen , have resolved the conflicts. Let me know there is any issue. Thanks !

@KoenZomers KoenZomers added status:checked and ready for merge ✔ PR has been checked and is ready for merge and removed Needs: Attention 👋 labels Jun 8, 2020
@erwinvanhunen erwinvanhunen merged commit 1d69796 into pnp:dev Jun 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:checked and ready for merge ✔ PR has been checked and is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants