Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TaxonomyPicker control does not show an error message for an invalid/unresolved input #728

Closed
1 of 3 tasks
devangbhavsar89 opened this issue Nov 11, 2020 · 4 comments
Closed
1 of 3 tasks
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Milestone

Comments

@devangbhavsar89
Copy link

devangbhavsar89 commented Nov 11, 2020

Category

  • Enhancement
  • Bug
  • Question

Version

Version of the library: [2.1.0]

Expected / Desired Behavior

I recently came across a scenario, where it would be beneficial to indicate some sort of an error beneath the control whenever user inputs any invalid text (which is not able to resolve into a valid term) inside taxonomy picker control.

The same kind of behavior is also visible with OOTB Page Details action (that opens a panel on right side).
image

Implementation Suggestion: It can be achieved inside <TaxonomyPicker /> control by triggering onBlur() and onInputChange() handlers that exists in TermBasePicker base component. All necessary validations can be done inside these handlers and an error message can be shown accordingly.

Observed Behavior

At the moment, such invalid/unresolved input is just ignored. And hence, it goes unnoticed from end-users point of view, while submitting the form.

Thanks!

@ghost
Copy link

ghost commented Nov 11, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 11, 2020
devangbhavsar89 pushed a commit to devangbhavsar89/sp-dev-fx-controls-react that referenced this issue Nov 11, 2020
@devangbhavsar89
Copy link
Author

Implemented code changes needed for this bug/enhancement and created a PR #729 for it.

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability and removed Needs: Triage 🔍 labels Nov 18, 2020
@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Nov 18, 2020
devangbhavsar89 pushed a commit to devangbhavsar89/sp-dev-fx-controls-react that referenced this issue Nov 21, 2020
…t inside taxonomy picker control (v1-release)
@devangbhavsar89
Copy link
Author

Also implemented the same changes for v1 release and created a PR #738, after it was requested here.

@devangbhavsar89
Copy link
Author

devangbhavsar89 commented Nov 21, 2020

Closing the issue, as it will now be taken care of (after implementation of new validateInput prop), in latest version (2.2.0 and 1.21.1) of @pnp/spfx-controls-react.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:enhancement New feature or enhancement of existing capability
Projects
None yet
Development

No branches or pull requests

2 participants