Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PeoplePicker errorMessage not being removed #730

Closed
gbminnock opened this issue Nov 11, 2020 · 4 comments
Closed

PeoplePicker errorMessage not being removed #730

gbminnock opened this issue Nov 11, 2020 · 4 comments
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Milestone

Comments

@gbminnock
Copy link

gbminnock commented Nov 11, 2020

Category
[x ] Bug

Version
2.0.0

Expected / Desired Behavior / Question
When a user is picked I run some custom validation on the user. If the user is invalid an error message should show.
If this user is cleared and another user is selected where the user passes the validation then the error message should be cleared.

Observed Behavior

  1. PeoplePicker uses errorMessage to display an error (if a user does not pass some validation logic).
  2. Error message variable is passed to PeoplePicker as a prop.
  3. If user is invalid error message is shown.
  4. If this user is removed and another added which is a valid user then the errorMessage should clear but it does not.
    4.1 I can see that my prop for errorMessage contains the correct value "".
    4.2 But I can see that the PeoplePicker contains a state value for errorMessage from the previous selected user.

Please see react component of peoplepicker

image

thanks,
Gary

@ghost
Copy link

ghost commented Nov 11, 2020

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 label Nov 11, 2020
@tarcisiopqdt
Copy link

I've same problem

AJIXuMuK added a commit that referenced this issue Nov 18, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @gbminnock,
Thank you for reporting this one!

It has been fixed and will be available in the next release.

In a meanwhile you can test the functionality in the beta version

@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue will be fixed in upcoming release. type:bug and removed Needs: Triage 🔍 labels Nov 18, 2020
@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Nov 18, 2020
@estruyf estruyf mentioned this issue Dec 3, 2020
@AJIXuMuK AJIXuMuK closed this as completed Dec 3, 2020
@NickRCarlson
Copy link

This issue does not appear to be resolved. I'm using version 3.0 and have even downgraded to 2.6 and I'm seeing the same behavior descripted in this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:fixed-next-drop Issue will be fixed in upcoming release. type:bug
Projects
None yet
Development

No branches or pull requests

4 participants