DateTimePicker Control #240
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #240 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 16 16
Lines 744 744
Branches 148 148
=======================================
Hits 541 541
Misses 159 159
Partials 44 44
Continue to review full report at Codecov.
|
robert-lindstrom
added a commit
to SherpasGroup/sp-dev-fx-controls-react
that referenced
this pull request
Mar 22, 2019
robert-lindstrom
added a commit
to SherpasGroup/sp-dev-fx-controls-react
that referenced
this pull request
Mar 22, 2019
robert-lindstrom
added a commit
to SherpasGroup/sp-dev-fx-controls-react
that referenced
this pull request
Mar 22, 2019
robert-lindstrom
added a commit
to SherpasGroup/sp-dev-fx-controls-react
that referenced
this pull request
Mar 22, 2019
robert-lindstrom
added a commit
to SherpasGroup/sp-dev-fx-controls-react
that referenced
this pull request
Mar 22, 2019
Closed
|
@AJIXuMuK closing this one, as we merged the other DateTime control. Thanks for the work you did and the validation / testing of the other control! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
The PR contains new DateTimePicker control.
It is based on PropertyFieldDateTimePicker control but with some redesigned aspects:
tablemarkup is changed withdisplay: flexmarkupDateobjects instead ofIDateTimeFieldValueformatDateis now used to format date inDatePickerDatePickerstrings, min and max date, flag to show or hide seconds dropdown