-
Notifications
You must be signed in to change notification settings - Fork 380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A date Picker control #21
Comments
Hello everyone, I can help with this. |
I created a PR for adding a DateTimePicker (#255) not realizing that a PR (#240) already existed. I am very interested in seeing a DateTimePicker merged and wanted to start a discussion around this. Not sure if this is the right place but I will start here. Some comments regarding my PR: After realizing the existence of #240 I ported some of it's features to this PR. @AJIXuMuK I hope this was ok? Noteably:
I intentionally left out the minDate and maxDate properties since I think they (if supported) should validate the entire Date object including hours, minutes and seconds, not just the date part as the #240 implementation does. Hopefully, this post can start a discussion that leads to a DateTimePicker being merged soon. What are your thougths @estruyf @AJIXuMuK? |
Hi @robert-lindstrom! |
@robert-lindstrom @AJIXuMuK I have also a version lying around with |
Just pushed my changes. Feel free to test it out in the following branch: https://github.com/SharePoint/sp-dev-fx-controls-react/tree/SherpasGroup-AddDateTimePickerControl The hours, minutes and seconds components make use of the What do you guys think @robert-lindstrom @AJIXuMuK? |
@estruyf I like that! |
Merged it to the DEV branch, so this can now be tested out in the latest beta and will be available in |
The new version is now building and will be released in a couple of minutes. |
Category
[ x] Enhancement
A datepicker that works like the classic datepicker-- has an option to include time, or not.
The text was updated successfully, but these errors were encountered: