Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List Item Picker option to select a key column #355

Merged
merged 2 commits into from
Oct 8, 2019
Merged

Conversation

mellolr1
Copy link

@mellolr1 mellolr1 commented Aug 9, 2019

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added the option to select a column to be the key / value of the select.
columnInternalName: is used for the text portion,
valueColumnInternalName?: is used for the value portion of the selected option.

@msftclas
Copy link

msftclas commented Aug 9, 2019

CLA assistant check
All CLA requirements met.

AJIXuMuK added a commit that referenced this pull request Oct 8, 2019
@AJIXuMuK AJIXuMuK mentioned this pull request Oct 8, 2019
@AJIXuMuK AJIXuMuK merged commit 5a499d8 into pnp:dev Oct 8, 2019
@AJIXuMuK AJIXuMuK added this to the 1.15.0 milestone Oct 8, 2019
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Oct 8, 2019

Thank you @mellolr1 for this update.
It has been merged with small changes in #381

@estruyf estruyf mentioned this pull request Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants