Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ListItemPicker - Added new control property, "FilterList" #392

Merged
merged 5 commits into from
Nov 15, 2019
Merged

ListItemPicker - Added new control property, "FilterList" #392

merged 5 commits into from
Nov 15, 2019

Conversation

joaojmendes
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [X]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

Added new Control Property "FilterList", allows filter list items base on condition ($filter), and select item(s) on sub set of list Items.

@codecov-io
Copy link

codecov-io commented Oct 20, 2019

Codecov Report

Merging #392 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #392   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      164      154   -10     
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 856af11...959035b. Read the comment docs.

@AJIXuMuK AJIXuMuK mentioned this pull request Nov 15, 2019
AJIXuMuK added a commit that referenced this pull request Nov 15, 2019
@AJIXuMuK AJIXuMuK merged commit efd2240 into pnp:dev Nov 15, 2019
@AJIXuMuK
Copy link
Collaborator

Hi @joaojmendes!
Thank you for that feature!
The PR has been manually fixed in #416.
I have additionally renamed filterList property to filter so it would be more meaningful for users.

@AJIXuMuK AJIXuMuK added this to the 1.16.0 milestone Nov 15, 2019
@joaojmendes
Copy link
Collaborator Author

joaojmendes commented Nov 15, 2019 via email

@estruyf estruyf mentioned this pull request Dec 16, 2019
@pmeripe
Copy link

pmeripe commented Mar 11, 2020

Hello @joaojmendes,

Thanks for the update. How can I increase width of the control and set values from the list or array?
I mean already saved selected items from the control. However we do for fields in edit form.
Praveen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants