Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto translations for localization #456

Merged
merged 3 commits into from
Jan 16, 2020
Merged

Auto translations for localization #456

merged 3 commits into from
Jan 16, 2020

Conversation

siata13
Copy link
Contributor

@siata13 siata13 commented Jan 10, 2020

Q A
Bug fix? [ ]
New feature? [x]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

The PR contains scrips which executes the automatic translations of the missing or not-translated localization values. The translation is executed with Azure Cognitive Services
Supported languages are defined in the configuration file. To authenticate to the Azure Cognitive services, the build process should set subscriptionKey variable (process.env.subscriptionKey)

@codecov-io
Copy link

Codecov Report

Merging #456 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #456   +/-   ##
=======================================
  Coverage   73.31%   73.31%           
=======================================
  Files          18       18           
  Lines         802      802           
  Branches      154      154           
=======================================
  Hits          588      588           
  Misses        164      164           
  Partials       50       50

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db72114...2827331. Read the comment docs.

@estruyf
Copy link
Member

estruyf commented Jan 16, 2020

Thank you so much @siata13 for this! This is an amazing for our global localization story!

@estruyf estruyf merged commit 25437b4 into pnp:dev Jan 16, 2020
estruyf added a commit that referenced this pull request Jan 16, 2020
@estruyf estruyf mentioned this pull request Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants