Changes to IconPicker Fix Search bug and refresh list of Icons #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @joaojmendes for the fixes! |
|
Hey, |
|
Hello 😊 @russell gove<mailto:notifications@github.com>
Check if is this 😊
I will create a PR …
Cheers!
João
From: Russell gove <notifications@github.com>
Reply to: SharePoint/sp-dev-fx-controls-react <reply@reply.github.com>
Date: Sunday, 12 April 2020 at 00:58
To: SharePoint/sp-dev-fx-controls-react <sp-dev-fx-controls-react@noreply.github.com>
Cc: João Mendes <joao.j.mendes@outlook.com>, Mention <mention@noreply.github.com>
Subject: Re: [SharePoint/sp-dev-fx-controls-react] Changes to IconPicker Fix Search bug and refresh list of Icons (#533)
Hey,
could we get an option on this to show it in a dialog rather than a panel.? if we use a PropertyFieldCollectionData in a property pane it would be nice to have the icon picker show up in a dialog rather than another panel. This houle probably be an option on all the react controls.
thanks
russell
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#533 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AC7YHVPVTOUGRHOS4POP6RDRMD72PANCNFSM4MEFVF2A>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
Fix a search problem and refresh list of Icons and sorted by name.
Add the IconPicker control to the test webpart.