Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

new Teams picker Property Control #303

Merged
merged 3 commits into from
Oct 29, 2020
Merged

new Teams picker Property Control #303

merged 3 commits into from
Oct 29, 2020

Conversation

joaojmendes
Copy link
Collaborator

Q A
Bug fix? [ ]
New feature? [X ]
New sample? [ ]
Related issues? fixes #X, partially #Y, mentioned in #Z

What's in this Pull Request?

New Team Picker Control

@AJIXuMuK AJIXuMuK merged commit 0e4eb59 into pnp:dev Oct 29, 2020
@AJIXuMuK
Copy link
Collaborator

Hi @joaojmendes!
Thanks for the new control. The PR was merge with lots of changes:

  • documentation for the component has been added
  • site was replaced with team across the component. I understand that the code was copied from site picker, but it's good to rename things after copy-paste to be logically correct
  • MS Graph calls were changed:
    • /groups?$filter call has been changed with /me/joinedTeams?$filter. It allowed to use v1.0 instead of beta version and use permission scope that doesn't require admin consent
    • webUrl requests were combined into batch to decrease number of requests and improve the overall performance.

@AJIXuMuK AJIXuMuK added this to the 2.2.0 milestone Oct 29, 2020
@estruyf estruyf mentioned this pull request Dec 3, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joaojmendes @AJIXuMuK