Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring BF in Stats? #1465

Open
Fuzzysqurl opened this issue May 14, 2016 · 3 comments
Open

Ignoring BF in Stats? #1465

Fuzzysqurl opened this issue May 14, 2016 · 3 comments

Comments

@Fuzzysqurl
Copy link
Contributor

Would adding the following code at usagestats.cpp#L169 work to ignore recording stats for BF? I don't know how to test but I also don't see how this would cause an issue but still wanted to bring it up before I commit.

/*Ignore BF too*/   
  if (tier == "Battle Factory" || tier == "Battle Factory 6v6") { 
        return -1; 
    } 
@Fuzzysqurl
Copy link
Contributor Author

Oak mentioned Mixed Tiers should be ignored too. I support this as they don't record ranked stats and therefore break the page as well

@sulcata
Copy link
Contributor

sulcata commented May 14, 2016

I don't know if this would be overly complex, but perhaps a statsEnabled="true/false" in the tiers.xml file would work better and cover future changes?

@coyotte508
Copy link
Member

coyotte508 commented May 14, 2016

Yes, hardcoded is bad.
A quick solution is to add some js in the template files, a better one is a config file for StatsExtracter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants