Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Fix) Branding of phishing detection page #189

Merged
merged 2 commits into from
Nov 23, 2018
Merged

(Fix) Branding of phishing detection page #189

merged 2 commits into from
Nov 23, 2018

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Nov 12, 2018 •
edited
Loading

screen shot 2018-11-12 at 12 22 06

Could be checked with the opening of one of the phishing site from the list: https://github.com/MetaMask/eth-phishing-detect/blob/master/src/config.json

Also,

  • change repo name for wiki page reference
  • change repo name for posting a comment to PR with release

@ghost ghost assigned vbaranov Nov 12, 2018
@ghost ghost added the in progress label Nov 12, 2018
@vbaranov vbaranov added this to the NW release 4.9.0 milestone Nov 13, 2018
@vbaranov vbaranov merged commit ce217d5 into develop Nov 23, 2018
@ghost ghost removed the awaiting for review label Nov 23, 2018
@vbaranov vbaranov deleted the phishing-detect-branding branch November 23, 2018 10:37
@vbaranov vbaranov mentioned this pull request Nov 26, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patitonar patitonar patitonar approved these changes

@dennis00010011b dennis00010011b dennis00010011b approved these changes

@fvictorio fvictorio Awaiting requested review from fvictorio

Assignees

@vbaranov vbaranov

Labels
None yet
Projects
None yet
Milestone
NW release 4.9.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vbaranov @patitonar @dennis00010011b