Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Multiple outputs fields for contract calls #219

Merged
merged 24 commits into from
Dec 20, 2018

Conversation

vbaranov
Copy link
Collaborator

Built from #212

Multiple outputs fields support for calling methods has been added for contract type account.

screen shot 2018-12-11 at 19 19 19

@dennis00010011b
Copy link

@vbaranov
Execute method:should be ability to copy output data (at least addresses), needs add copy icons

@dennis00010011b
Copy link

@vbaranov
FireFox : screen Execute Method isn't scrollable if multiply outputs present
screen shot 2018-12-11 at 14 50 32

@dennis00010011b
Copy link

dennis00010011b commented Dec 11, 2018

@vbaranov
NW isn't usable in popup mode if user want to call method with two and more input parameters. User needs fill out two fields but can't copy/paste two parameters because the input field's value is lost after each closing NW
screen shot 2018-12-11 at 14 50 32

@vbaranov vbaranov added this to the NW release 4.10.1 milestone Dec 12, 2018
@vbaranov
Copy link
Collaborator Author

@dennis00010011b

Execute method:should be ability to copy output data (at least addresses), needs add copy icons

Good idea. Added here 267807f

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

FireFox : screen Execute Method isn't scrollable if multiply outputs present

Fixed fed6cee

@vbaranov
Copy link
Collaborator Author

NW isn't usable in popup mode if user want to call method with two and more input parameters. User needs fill out two fields but can't copy/paste two parameters because the input field's value is lost after each closing NW

Yeah, thinking about web page implementation. In a separate PR.

@dennis00010011b
Copy link

@vbaranov
LGTM, except minor UI issue in FireFox
screen shot 2018-12-14 at 10 11 01

@dennis00010011b
Copy link

dennis00010011b commented Dec 18, 2018

@vbaranov
Execute method returns incorrect value for uint32 and more. Value 'cutted' to uint16
Contract 0x8ba3f8618a33cd3f155477e889295a4c5ab52ae4, Sokol
Method returnUint which simple returns input, input data 11223344556677889911223344 , output 11223344556677888000000000

screen shot 2018-12-17 at 23 48 48

@dennis00010011b
Copy link

@vbaranov
Execute method always shows true for boolean return
Contract 0x8ba3f8618a33cd3f155477e889295a4c5ab52ae4, Sokol
Method returnBoolean
screen shot 2018-12-17 at 23 55 30

@dennis00010011b
Copy link

@vbaranov
Added types of returned values :bytes, int etc
0xab6f1fad0fb4bf7efa253210698c02bfd29ab370 Sokol

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

Execute method always shows true for boolean return
Contract 0x8ba3f8618a33cd3f155477e889295a4c5ab52ae4, Sokol
Method returnBoolean

Fixed f5b5652

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

Execute method returns incorrect value for uint32 and more. Value 'cutted' to uint16
Contract 0x8ba3f8618a33cd3f155477e889295a4c5ab52ae4, Sokol
Method returnUint which simple returns input, input data 11223344556677889911223344 , output 11223344556677888000000000

Fixed f46bb26

@dennis00010011b
Copy link

@vbaranov
Tested it. No issues were found

e2e: test different types of outputs for feature 'Ecxecute method'
@vbaranov vbaranov merged commit 712e415 into develop Dec 20, 2018
@ghost ghost removed the awaiting for review label Dec 20, 2018
@vbaranov vbaranov deleted the contract-call-multiple-outputs branch December 20, 2018 19:43
@vbaranov vbaranov mentioned this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants