Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Unlock back contract account on rejecting/accepting of contract execution transaction #238

Merged
merged 22 commits into from
Dec 28, 2018

Conversation

vbaranov
Copy link
Collaborator

Unlock back contract account on reject/reject all/accept of contract execution transaction

Relates to #212 (review)

@vbaranov
Copy link
Collaborator Author

@dennis00010011b could we add e2e tests

  • that unlocked account is changed to contract after reject/reject all*/submit tx
  • that unlocked account is not chnaged in other cases

*for reject all case unlocked acount is changed, if all txs to the same contract.

@vbaranov vbaranov added this to the NW release 4.10.1 milestone Dec 24, 2018
@vbaranov vbaranov changed the title (Fix) Unlock contract account on rejecting/accepting of contract execution transaction (Fix) Unlock back contract account on rejecting/accepting of contract execution transaction Dec 24, 2018
@dennis00010011b
Copy link

@vbaranov
It goes back to the sender account after contract execution if 'Buy ether' option had been selected during the submitting transaction.
Steps:

  1. Import contract 0x215B2Ab35749e5A9f3EFE890DE602fB9844E842f, Sokol
  2. Select method transfer
  3. Select executor the account with 0 balance. Click 'Next'
  4. Click button 'Buy ether'
  5. Click arrow button and return to the transaction screen
  6. Click button arrow or reject/reject all
  7. Observe account's address

Expected: should be contract's address
Actual: executor's address

@dennis00010011b
Copy link

@vbaranov
Arrow button always leads from 'Confirm transaction' screen to executor account. Should leads to contract account

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

Arrow button always leads from 'Confirm transaction' screen to executor account. Should leads to contract account

Yes, from account selection until a decision on tx: acception, rejection we are under executor. This is implemented by design.

@vbaranov
Copy link
Collaborator Author

@dennis00010011b

It goes back to the sender account after contract execution if 'Buy ether' option had been selected during the submitting transaction.

Fixed (11e2ad4 and eca9e0e)

@vbaranov vbaranov merged commit 798256f into develop Dec 28, 2018
@ghost ghost removed the awaiting for review label Dec 28, 2018
@vbaranov vbaranov deleted the change-to-contract-acc-after-execution branch December 28, 2018 12:28
@vbaranov vbaranov mentioned this pull request Dec 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants