(Feature) Reorder contract executors: owners are first #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
requested review from
fvictorio,
fernandomg,
patitonar and
dennis00010011b
ghost
assigned 
|
@vbaranov Input data:
As a result NW can't execute method |
Fixed 291089d |
fvictorio
approved these changes
Dec 26, 2018
e2e contract-executor-reorder
dennis00010011b
approved these changes
Dec 27, 2018
|
@dennis00010011b could you please resolve merging conflicts in e2e tests? |
fernandomg
reviewed
Dec 28, 2018
| @@ -113,6 +152,47 @@ class ChooseContractExecutor extends Component { | |||
| }) | |||
| } | |||
|
|
|||
| getAllOwners = () => { | |||
| this.props.showLoadingIndication() | |||
There was a problem hiding this comment.
May it be possible to add a catch to the promise so you can call hideLoadingIndicator if for any reason the Promise.all fails?
or you can refactor to use async/awaits? whatever fits best.
There was a problem hiding this comment.
Thanks @fernandomg! Catch was added.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an executed contract has
ownerorgetOwnersgetters, and addresses from the resulted array are in the list of wallet accounts, they will be first in the list in the Choose contract executor screen.